fix(compass-schema-validation): add generate button to the editor COMPASS-9145 #6809
+161
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
added
the
feature flagged
paula-stacho
changed the title
Anemy
reviewed
Mar 20, 2025
| <div className={generateButtonContainerStyles}> | ||
| <Button | ||
| data-testid="generate-rules-button" | ||
| disabled={!isEmpty} |
Member
There was a problem hiding this comment.
Should we allow for folks to click the button if they are on the default template also? I'm thinking they may click Add Rule then want to generate rules.
Collaborator
Author
There was a problem hiding this comment.
Perhaps? Maybe until they make any edits.. It feels weird to me though.. We can check with Julia and Misba
packages/compass-schema-validation/src/components/validation-editor.tsx
Outdated
Show resolved
Hide resolved
Anemy
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forgot about this when implementing the rules generation.
The button is enabled when the validator is empty (either empty string or empty object). Editor to be editable but doesn't have to be in the edit mode (that would be an extra click for the same action). Button is in loading state when the generation is in progress.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes